Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase cached state disk sizes to 400 GB #7684

Merged
merged 2 commits into from
Oct 9, 2023
Merged

Increase cached state disk sizes to 400 GB #7684

merged 2 commits into from
Oct 9, 2023

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Oct 5, 2023 •
edited
Loading

Motivation

We're at 280 GB of 300 GB, and getting much closer could cause weird errors or intermittent failures.

Solution

Increase cached state disk sizes to 400 GB.

We don't need big boot disks, they just cost us money, so decrease them to 50 GB.

Review

This PR only needs to be merged within the next few months, so it's a low priority.

Reviewer Checklist

  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 5, 2023
@teor2345 teor2345 changed the title Try larger cached state disk sizes Increase cached state disk sizes to 400 GB Oct 5, 2023
@teor2345 teor2345 self-assigned this Oct 5, 2023
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Low ❄️ I-integration-fail Continuous integration fails, including build and test failures labels Oct 5, 2023
@teor2345 teor2345 marked this pull request as ready for review October 8, 2023 22:24
@teor2345 teor2345 requested a review from a team as a code owner October 8, 2023 22:24
@teor2345 teor2345 requested review from upbqdn and removed request for a team October 8, 2023 22:24
@teor2345
Copy link
Contributor Author

teor2345 commented Oct 9, 2023

Failed due to issue #7659, I've restarted it.

gustavovalverde
gustavovalverde approved these changes Oct 9, 2023
View reviewed changes
Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot added a commit that referenced this pull request Oct 9, 2023
@mergify
Merge of #7684
998b64f
@mergify mergify bot mentioned this pull request Oct 9, 2023
Closed
@mergify mergify bot merged commit a2b7859 into main Oct 9, 2023
115 checks passed
@mergify mergify bot deleted the disk-sizes branch October 9, 2023 03:10
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gustavovalverde gustavovalverde gustavovalverde approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @gustavovalverde