ref(workflows): use a single job to run GCP tests #7682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error:
```
Validation Failed: {"resource":"Release","code":"invalid","field":"target_commitish"}
```
Fixes: release-drafter/release-drafter#1125
gustavovalverde
requested review from
oxarbitrage
and removed request for
a team
github-actions
bot
added
the
C-trivial
gustavovalverde
added
A-infrastructure
teor2345
reviewed
Oct 12, 2023
There was a problem hiding this comment.
This looks good! Thank you for this cleanup.
Is there a description of how the workflow works now? Can we add that to the top of this workflow?
It looks like you merged all 3 of the cases in the PR description into the same job, but also made some other changes to simplify pipe handling. Is there any other significant change here?
teor2345
reviewed
Oct 12, 2023
Co-authored-by: teor <[email protected]>
6 tasks
|
I removed the |
teor2345
approved these changes
Oct 18, 2023
|
@gustavovalverde I just saw this $DISK_NAME fix follow-up again in my final review: It would be ok to copy the same script you use to find the disk name into that SSH command. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To be able to handle edge-cases and complex scenarios (launch step no failing, but test-result failint and not being able to re-run it), and for the sake of simplicity, this PR proposes using a single job for handling all the following scenarios:
Complex Code or Requirements
This is a very delicate change, even though is simplifying the process, as it has to consider multiple scenarios which were using multiple jobs and steps, and now it's using a single job and some steps have been merged.
Solution
$DISK_OPTIONand$MOUNT_FLAGSto allow flexibility when mounting the volumes.Review
Reviewer Checklist
Follow Up Work
Move the scripts out of the workflow.