Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ci): wait for disk to be mounted in VM #7662

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(ci): wait for disk to be mounted in VM #7662

merged 1 commit into from
Oct 4, 2023

Conversation

gustavovalverde
Copy link
Member

Motivation

Lately, mounting the disk by Docker has been unreliable, the root cause might be different things, but in the end we should confirm the disk is mounted before running the container with disk being mounted or busy

Fixes: #7659

Solution

Add a wait command: while [[ ! -e /dev/sdb ]]; do sleep 1; done

Review

We might want to run this PR multiple times if it works at first, just to confirm multiple runs (4+) will output the same result.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
    • Does it change concurrent code, unsafe code, or consensus rules?
  • How do you know it works? Does it have tests?

@gustavovalverde gustavovalverde added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-Critical 🚑 I-integration-fail Continuous integration fails, including build and test failures labels Oct 3, 2023
@gustavovalverde gustavovalverde self-assigned this Oct 3, 2023
@github-actions github-actions bot added the C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG label Oct 3, 2023
@gustavovalverde gustavovalverde marked this pull request as ready for review October 3, 2023 21:33
@gustavovalverde gustavovalverde requested a review from a team as a code owner October 3, 2023 21:33
@gustavovalverde gustavovalverde requested review from upbqdn and removed request for a team October 3, 2023 21:33
teor2345
teor2345 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, looks good to me!

I am happy to try it on the main branch, and do extra fixes in another PR if needed.

@teor2345
Copy link
Contributor

teor2345 commented Oct 4, 2023

This is failing due to bug #7661, so I think we should admin-merge it, so we can fix the lightwalletd cached state and zebrad sync bugs.

@gustavovalverde gustavovalverde merged commit 3248c4c into main Oct 4, 2023
110 of 113 checks passed
@gustavovalverde gustavovalverde deleted the fix-docker-disk-mount branch October 4, 2023 08:25
@gustavovalverde
Copy link
Member Author

Admin-merged

This was referenced Oct 4, 2023
Merged
Closed
@upbqdn upbqdn mentioned this pull request Oct 13, 2023
Merged
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teor2345 teor2345 teor2345 approved these changes

@upbqdn upbqdn Awaiting requested review from upbqdn upbqdn is a code owner automatically assigned from ZcashFoundation/devops-reviewers

Assignees

@gustavovalverde gustavovalverde

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-integration-fail Continuous integration fails, including build and test failures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI failing with mounting volume error
2 participants
@gustavovalverde @teor2345