fix(ci): handle tee trying to write to a closed pipe

[gustavovalverde]

Motivation

This issue happens even if there's not an actual failure in integration tests.

tee: 'standard output': Broken pipe
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 44 filtered out; finished in 2.11s
sudo docker exit status: 101
Error: Process completed with exit code 101.

Fixes #7564

Complex Code or Requirements

trap '' PIPE is a not a very intuitive command.

Solution

Use trap '' PIPE as a command in the pipeline might exit early and we want the script to continue executing, as using grep --max-count=1 might exit after finding the first match, causing a broken pipe error with tee. This is being combined with set -o pipefail to have strict error handling, as we want the script to fail if any command in the pipeline fails.

Review

We should confirm this part of CI is being tested and passes as expected.

Reviewer Checklist

• Will the PR name make sense to users?
  • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
• Are the PR labels correct?
• Does the code do what the ticket and PR says?
  • Does it change concurrent code, unsafe code, or consensus rules?
• How do you know it works? Does it have tests?

Follow Up Work

N/A

[teor2345]

This is being combined with set -o pipefail to have strict error handling, as we want the script to fail if any command in the pipeline fails.

This is just for interest, I want to avoid any other changes in a bug fix PR:
http://redsymbol.net/articles/unofficial-bash-strict-mode/

Other possible settings are:

• set -u: fail if variables are unset
• set -x: show all the code that is executed (GitHub already does this, but only for top-level commands), this will also interfere with the exit status check

[teor2345]

We just agreed that I wouldn't do DevOps reviews any more 😅

[arya2]

Looks good!