Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow clippy lint #103

Merged
merged 3 commits into from
Oct 17, 2023
Merged

Allow clippy lint #103

merged 3 commits into from
Oct 17, 2023

Conversation

oxarbitrage
Copy link
Contributor

In the last clippy version it seems there is a new lint or an update of it unwrap_or_default.

Code from zcashd will trigger the lint will will make the CI fail: https://github.com/zcash/zcash/blob/v5.7.0/src/rust/src/wallet.rs#L540

This pull request will allow the lint until it is fixed.

@oxarbitrage oxarbitrage added github_actions Pull requests that update GitHub Actions code bug Something isn't working dependencies Pull requests that update a dependency file labels Oct 12, 2023
@oxarbitrage oxarbitrage mentioned this pull request Oct 13, 2023
@conradoplg
Copy link
Contributor

I think it's better to allow it in lib.rs so that it works everywhere and not only in our CI. Since I had already made the change to test it I went ahead and committed it, let me know if you agree with it @oxarbitrage

@oxarbitrage
Copy link
Contributor Author

Yea, sorry, i didn't knew we had that. Thanks for the fix.

@conradoplg conradoplg merged commit 36de930 into master Oct 17, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants