Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server: support private key authentication #381

Merged
merged 3 commits into from
Dec 18, 2024
Merged

server: support private key authentication #381

merged 3 commits into from
Dec 18, 2024

Conversation

conradoplg
Copy link
Contributor

@conradoplg conradoplg commented Nov 23, 2024

Closes #334

This adds support for private key authentication to the server.

It also changes the frost-client participant and coordinator commands to use it, making username&password not used.

I think we can now remove username&password support and clean up a lot of code. However I thought it would be best to do that in a separate PR which I'll create as a follow up to this.

To test (adjust / run in different terminals where needed)

cargo run -p frost-client -- init -c alice.toml
cargo run -p frost-client -- init -c bob.toml
cargo run -p frost-client -- init -c eve.toml
RUST_LOG=debug cargo run --bin server
# Replace group pubkey and user pubkeys
cargo run -p frost-client -- coordinator -c alice.toml --server-url localhost:2744 --group c0e56fbe3b18eb4536b48a1c50eea7966bead731e203c8eb34af2a3aa43d1e19 -S 5c6024bf25bbd40ac1b4168cc0b5b766c4c546c00accfc2289389a2eabc8b348,58189d9af5a749bf6bf466c97ab5cdf6ed9ce61cec5087ca42bba736cdd2ac55 -m msg.raw
cargo run -p frost-client -- participant -c alice.toml --server-url localhost:2744 --group c0e56fbe3b18eb4536b48a1c50eea7966bead731e203c8eb34af2a3aa43d1e19
cargo run -p frost-client -- participant -c bob.toml --server-url localhost:2744 --group c0e56fbe3b18eb4536b48a1c50eea7966bead731e203c8eb34af2a3aa43d1e19

@mpguerra mpguerra linked an issue Nov 25, 2024 that may be closed by this pull request
@conradoplg conradoplg marked this pull request as ready for review November 25, 2024 16:17
@@ -53,14 +81,24 @@ pub struct GetSessionInfoArgs {
pub struct GetSessionInfoOutput {
pub num_signers: u16,
pub message_count: u8,
pub usernames: Vec<String>,
pub coordinator: String,
pub pubkeys: Vec<Vec<u8>>,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also use PublicKey from below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in d3404b6

Copy link
Contributor

@natalieesk natalieesk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@natalieesk natalieesk merged commit fe7ea0a into main Dec 18, 2024
5 checks passed
@natalieesk natalieesk deleted the key-auth branch December 18, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add private key authentication
2 participants