Fix FidoMetadataDownloader failure on unknown properties #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(git cherry-pick a62d4c8) Fixes this build failure that suddenly occurred with no code changes: ``` $ ./gradlew :webauthn-server-core:compileTestScala Execution failed for task ':webauthn-server-core:compileTestScala'. > bad constant pool index: 0 at pos: 89856 while compiling: ./webauthn-server-core/src/test/scala/com/yubico/scalacheck/gen/JacksonGenerators.scala during phase: globalPhase=typer, enteringPhase=namer library version: version 2.13.8 compiler version: version 2.13.8 reconstructed args: [9876 characters redacted for brevity] last tree to typer: Ident(com) tree position: line 35 of ./webauthn-server-core/src/test/scala/com/yubico/scalacheck/gen/JacksonGenerators.scala tree tpe: com.type symbol: final package com symbol definition: final package com (a ModuleSymbol) symbol package: <none> symbol owners: package com call site: package gen in package scalacheck in package scalacheck == Source file context for tree position == 32 import com.fasterxml.jackson.databind.node.NumericNode 33 import com.fasterxml.jackson.databind.node.ObjectNode 34 import com.fasterxml.jackson.databind.node.TextNode 35 import com.upokecenter.cbor.CBORObject 36 import com.yubico.internal.util.JacksonCodecs 37 import org.scalacheck.Arbitrary 38 import org.scalacheck.Arbitrary.arbitrary ```
(git cherry-pick f242370)
(git cherry-pick 3a67ec4) The `ignoreSourceSets` config is needed to fix errors like this: ``` Execution failed for task ':yubico-util:configSemanticDBMain'. > Failed to calculate the value of task ':yubico-util:configSemanticDBMain' property 'scalaVersion'. > Unable to detect the Scala version for the 'main' source set. Please ensure it declares dependency to scala-library or consider adding it to 'ignoreSourceSets' ``` The change to `project-convention-code-formatting-internal.gradle` is needed to fix this error: ``` Execution failed for task ':yubico-util-scala:compileScala'. > Could not resolve all files for configuration ':yubico-util-scala:detachedConfiguration1'. > Could not find org.scalameta:semanticdb-scalac_2.13.13:4.5.5. Searched in the following locations: - https://repo.maven.apache.org/maven2/org/scalameta/semanticdb-scalac_2.13.13/4.5.5/semanticdb-scalac_2.13.13-4.5.5.pom If the artifact you are trying to retrieve can be found in the repository but without metadata in 'Maven POM' format, you need to adjust the 'metadataSources { ... }' of the re pository declaration. Required by: project :yubico-util-scala ```
``` git checkout 240b8d9 -- build.gradle settings.gradle.kts buildSrc/ */build.gradle.kts ```
emlun
force-pushed
the
fido-mds-unknown-fields
branch
from
54efa19 to
f384e8e
Compare
|
Confirming that the integration test workflow fails correctly: https://github.com/Yubico/java-webauthn-server/actions/runs/10683857466 |
Test Results1 309 tests 1 305 ✅ 53s ⏱️ Results for commit 63bc71b. ♻️ This comment has been updated with latest results. |
georgespalding
approved these changes
Sep 3, 2024
dainnilsson
approved these changes
Sep 3, 2024
fdennis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #375.
The first three commits are cherry-picks from
mainto fix the Gradle build being broken.