Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/block building #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat/block building #3

wants to merge 1 commit into from

Conversation

EgoSay
Copy link

@EgoSay EgoSay commented Dec 22, 2024

  1. translation of block building
  2. the part of geth code is out of date, update translation with geth latest version: release-1.14.9

wfnuser
wfnuser requested changes Dec 22, 2024
View reviewed changes
src/images/block-building/payload-building-routine.png Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

图片应该都引进来了 不用额外增加 你找找原本的？

src/block-building.md Outdated Show resolved Hide resolved
@wfnuser
Copy link
Member

wfnuser commented Dec 22, 2024 •
edited
Loading

Good job! But please squash 3 commits to one.

@EgoSay
feat(block building): translation
5aaaef3 
feat(block building): translation

feat(block building): translation of new geth version

fix: update translation

fix: update translation
@EgoSay EgoSay force-pushed the feat/block-building branch from 2a0c712 to 5aaaef3 Compare December 22, 2024 12:42
@EgoSay
Copy link
Author

EgoSay commented Dec 22, 2024

I've addressed all your comments, please review again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wfnuser wfnuser wfnuser requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EgoSay @wfnuser