Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp design #5

Merged
merged 1 commit into from
Feb 20, 2020
Merged

Revamp design #5

merged 1 commit into from
Feb 20, 2020

Conversation

kdsch
Copy link
Contributor

@kdsch kdsch commented Feb 20, 2020

Broadly, I want to make the design more accessible and clean up implementation as I go. I freely made changes. I welcome feedback and corrections.

Design improvements

  • Limit line length to 2 to 3 alphabets
  • Reduce use of solid rectangles
  • Gently adapt font size and white space to screen width, accommodating mobile devices
  • Simplify the newsletter signup form
  • Use a little color

Implementation improvements

  • Factor out inline CSS
  • Reduce unnecessary use of Hugo abstractions, particularly partial templates
  • Remove unused code. At the time of writing, I have not removed everything that I know to be unused.

@kdsch kdsch requested a review from cbrake February 20, 2020 16:06
@kdsch
Copy link
Contributor Author

kdsch commented Feb 20, 2020

The main improvement on mobile: clearer menu and the entire form is above the fold.

iPhone 6 old

image

iPhone 6 new

image

@cbrake
Copy link
Contributor

cbrake commented Feb 20, 2020

@kdsch text/fonts looks much cleaner.

What does the little circle mean by links?

I like the arrows next to menu options that take you offsite.

Underline of menu options is clean and nice.

(Disclaimer -- I'm not a designer, so be patient with me :-) )

A few thoughts:

Of the examples above, I probably like the elm site about the best. Are there any sites you know of that would be good examples to pattern after?

I'll merge and deploy what you have done so far, and we can go from there.

@cbrake cbrake merged commit 29d4540 into YoeDistro:master Feb 20, 2020
@cbrake cbrake mentioned this pull request Feb 20, 2020
@kraj
Copy link
Contributor

kraj commented Feb 20, 2020

good improvements I must say, I think small logo would be good to have perhaps, but I am also in same boat at Cliff ( He is my designer guru)

@cbrake
Copy link
Contributor

cbrake commented Feb 20, 2020

lets continue design discussion @ #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants