Skip to content

Commit

Permalink
Merge pull request #2 from butugruv/issue-1
Browse files Browse the repository at this point in the history
Completed MVP
  • Loading branch information
Yng808 authored Jan 25, 2024
2 parents 60940a1 + b6222e4 commit 07649d7
Show file tree
Hide file tree
Showing 41 changed files with 29,871 additions and 34,484 deletions.
4 changes: 2 additions & 2 deletions spfx/.eslintrc.js → .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ module.exports = {
// or else return the object to a caller (who assumes this responsibility). Unterminated
// promise chains are a serious issue. Besides causing errors to be silently ignored,
// they can also cause a NodeJS process to terminate unexpectedly.
'@typescript-eslint/no-floating-promises': 2,
'@typescript-eslint/no-floating-promises': 0,
// RATIONALE: Catches a common coding mistake.
'@typescript-eslint/no-for-in-array': 2,
// STANDARDIZED BY: @typescript-eslint\eslint-plugin\dist\configs\recommended.json
Expand Down Expand Up @@ -189,7 +189,7 @@ module.exports = {
// STANDARDIZED BY: eslint\conf\eslint-recommended.js
'no-control-regex': 2,
// STANDARDIZED BY: eslint\conf\eslint-recommended.js
'no-debugger': 1,
'no-debugger': 0,
// STANDARDIZED BY: eslint\conf\eslint-recommended.js
'no-delete-var': 2,
// RATIONALE: Catches code that is likely to be incorrect
Expand Down
44 changes: 44 additions & 0 deletions .github/workflows/webpack.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
name: Build & Package

on:
project:
types: [closed]
pull_request:
types: [closed]
release:
types: [published]
workflow_dispatch:

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [16.x]

steps:
- uses: actions/checkout@v2

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}

- name: Install Libraries
run: |
npm install
cd spfx
npm install
cd ..
- name: Build
run: |
npm run all
- name: Artifacts
uses: actions/upload-artifact@v2
with:
name: artifacts
path: |
sharepoint/solution/better-hero.sppkg
35 changes: 34 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,34 @@
node_modules/
# Logs
logs
*.log
npm-debug.log*

# Dependency directories
node_modules

# Build generated files
dist
lib
release
solution
temp
*.sppkg
.heft

# Coverage directory used by tools like istanbul
coverage

# OSX
.DS_Store

# Visual Studio files
.ntvs_analysis.dat
.vs
bin
obj

# Resx Generated Code
*.resx.ts

# Styles Generated Code
*.scss.ts
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion spfx/.yo-rc.json → .yo-rc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
},
"version": "1.18.2",
"libraryName": "better-hero",
"libraryId": "87b658de-3190-4eef-b701-dc7ba6411b8d",
"libraryId": "77645465-e030-47de-99c9-07f4f53f3b68",
"environment": "spo",
"packageManager": "npm",
"solutionName": "BetterHero",
Expand Down
File renamed without changes.
18 changes: 0 additions & 18 deletions clean.js

This file was deleted.

File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/package-solution.schema.json",
"solution": {
"name": "better-hero-client-side-solution",
"id": "87b658de-3190-4eef-b701-dc7ba6411b8d",
"version": "1.0.0.0",
"id": "77645465-e030-47de-99c9-07f4f53f3b68",
"version": "0.0.0.1",
"includeClientSideAssets": true,
"skipFeatureDeployment": true,
"isDomainIsolated": false,
Expand All @@ -29,12 +29,12 @@
{
"title": "better-hero Feature",
"description": "The feature that activates elements of the better-hero solution.",
"id": "bfb4a547-3aef-45a3-a025-a276c95460e6",
"id": "91777c98-5799-464d-91c4-67da5717c563",
"version": "1.0.0.0"
}
]
},
"paths": {
"zippedPackage": "../../dist/sp-dashboard.sppkg"
"zippedPackage": "solution/better-hero.sppkg"
}
}
File renamed without changes.
2 changes: 1 addition & 1 deletion spfx/config/serve.json → config/serve.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@
"$schema": "https://developer.microsoft.com/json-schemas/spfx-build/spfx-serve.schema.json",
"port": 4321,
"https": true,
"initialPage": "https://{tenantDomain}/_layouts/workbench.aspx"
"initialPage": "https://5vvxxh.sharepoint.com/_layouts/workbench.aspx"
}
File renamed without changes.
File renamed without changes.
Loading

0 comments on commit 07649d7

Please sign in to comment.