Add focus-window-previous action
#811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaLTeR
reviewed
Nov 18, 2024
|
Been using this for a few days now without issue, so it's ready for a final review :) |
|
Yeah, sorry, I have this checked out, but I've been very busy with uni. |
|
Did some minor cleanups |
|
Hmm, what if we store the previous focused window just in the Niri state itself, rather than on each window? I think that should be simpler and should fix the layer-shell edge cases. I'll try doing it tomorrow when my brain is a bit clearer |
|
Could you please try this branch again? I made the change above. |
Will do. This approach also does look nicer. |
|
Appears to be working as intended! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This action focuses the previously focused window. As a parallel to
focus-workspace-previous, this works across outputs, or within the same workspace, and should come in handy for users that have scripts making use offocus-window.