Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard.repeat-rate and keyboard.repeat-delay #8

Merged
merged 1 commit into from
Sep 16, 2023

Conversation

kchibisov
Copy link
Contributor

Add option to let the users configure the keyboard repeat delay and rate. Also change the default values to mimic the Xorg, which is also the values used by default by the majority of the compositors.

@kchibisov kchibisov force-pushed the repeat-rate-and-delay branch from b754366 to 95a8a71 Compare September 16, 2023 09:00
Copy link
Owner

@YaLTeR YaLTeR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, just a question about the defaults.

// Control the repeat rate of the keyboard.

// Repeat delay in milliseconds.
repeat-delay 200
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this 200? Sway and wlroots default to 600. My GNOME install has 500 (I haven't changed it).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, yeah, it could be actually 600. I just remember that we picked the 200 for sctk/anvil at some point, but I don't remember why 200 exactly, maybe I've pushed all of that in the end.

It's 660 in the Xorg actually, but the 25 value is accurate.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add option to let the users configure the keyboard repeat delay and
rate. Also change the default values to mimic the Xorg, which is
also the values used by default by the majority of the compositors.

Fixes: YaLTeR#7
@kchibisov kchibisov force-pushed the repeat-rate-and-delay branch from 95a8a71 to 22bd91f Compare September 16, 2023 09:08
@YaLTeR YaLTeR merged commit b66b439 into YaLTeR:main Sep 16, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants