Improve layout handling #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kchibisov
force-pushed
the
keyboard-layouts
branch
from
91ff670 to
ac57c7a
Compare
kchibisov
force-pushed
the
keyboard-layouts
branch
from
ac57c7a to
b6df676
Compare
YaLTeR
reviewed
Nov 2, 2023
resources/default-config.kdl
Outdated
Comment on lines
220
to
227
| // Actions to switch layouts. | ||
| //Mod+Space { switch-layout "next"; } | ||
| //Mod+Shift+Space { switch-layout "prev"; } |
There was a problem hiding this comment.
Suggested change
| // Actions to switch layouts. | |
| //Mod+Space { switch-layout "next"; } | |
| //Mod+Shift+Space { switch-layout "prev"; } | |
| // Keyboard layout switching. | |
| Mod+Space { switch-layout "next"; } | |
| Mod+Shift+Space { switch-layout "prev"; } |
This makes sense to have by default I think.
There was a problem hiding this comment.
Not really, Most folks switch in xkb options.
There was a problem hiding this comment.
It shouldn't conflict with xkb switching right?
There was a problem hiding this comment.
They don't conflict, it's just not everyone use multiple layouts, it's normally just one.
resources/default-config.kdl
Outdated
Comment on lines
20
to
25
| // How compositor should track the layout. | ||
| // | ||
| // - "global" - layout change is global for all windows. | ||
| // - "window" - layout is tracked for each window individually. | ||
| // | ||
| //track-layout "global" |
There was a problem hiding this comment.
I think this would make more sense as a boolean toggle:
Suggested change
| // How compositor should track the layout. | |
| // | |
| // - "global" - layout change is global for all windows. | |
| // - "window" - layout is tracked for each window individually. | |
| // | |
| //track-layout "global" | |
| // Uncomment this line to make the layout change per-window, rather than globally. | |
| // per-window-layout |
There was a problem hiding this comment.
I'm not sure about boolean, the enum is at lest clear what it does by default.
YaLTeR
force-pushed
the
keyboard-layouts
branch
2 times, most recently
from
ef92e16 to
ac90c46
Compare
This should allow users of non-latin layouts use bindings without changing layout back to latin input capable one. Fixes YaLTeR#21.
YaLTeR
force-pushed
the
keyboard-layouts
branch
from
ac90c46 to
b84b42b
Compare
Allow users to trigger layout change with custom bindings.
Track layout for each window individually when user requested `Window` tracking mode, keeping the default as global.
YaLTeR
force-pushed
the
keyboard-layouts
branch
from
b84b42b to
052bbb4
Compare
|
Did some minor changes. Should be good to merge now? |
YaLTeR
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review by commit and then rebase. Draft until upstream merges changes.