Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 / ✨ Fix Literal Chat Reload + Secret Parameter Input Dialog + Add Secret/Any Arguments #361

Merged
merged 6 commits into from
Oct 30, 2024

Conversation

MFA-X-AI
Copy link
Member

Description

This PR:

  • fixes literal chats from incorrectly adding escaped jsons when reloaded
  • prevents the browser save password dialog when inputting data in the literal secret dialog
  • adds argument secret and argument any

References

If applicable, note issue numbers this pull request addresses. You can also note any other pull requests that address this issue and how this pull request is different.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

  1. Test Literal Chat Reload
  • Verify that reloading a literal chat does not add escaped JSON data.
  1. Test Literal Secret Dialog Password Prompt
  • Verify that the browser’s "Save Password" dialog does not appear when entering data in the literal secret dialog.
  1. Test New Argument "Secret"
  • Verify that the "secret" argument can be added and functions as expected. It also should not spawn any windows just like Literals.
  1. Test New Argument "Any"
  • Verify that the "any" argument can be added and functions correctly.

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Copy link

Binder 👈 Launch a binder notebook on branch XpressAI/xircuits/fahreza/secret-chat-fix

@MFA-X-AI MFA-X-AI merged commit 7afbc20 into master Oct 30, 2024
8 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/secret-chat-fix branch October 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant