🐛 Prevent Event Propagation to Other Widgets #358
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds event handling logic to fully stop keyboard event propagation (
preventDefault()
,stopPropagation()
,stopImmediatePropagation()
) inCustomActionEvent
. This ensures key commands likeCtrl+Z
only affect the active xircuits canvas and do not interfere with other JupyterLab widgets like text editors when they are not active.References
#254
Pull Request Type
Type of Change
Tests
Ctrl+Z
,Ctrl+Y
, etc., only impact the active Xircuits canvas.Tested on?