Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Enable Output Panel Spawn Location Through Config #266

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

MFA-X-AI
Copy link
Member

@MFA-X-AI MFA-X-AI commented Sep 28, 2023

Description

This PR allows users to specify the output panel and log panel spawn location via config.ini.

References

#241

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Test Update Output Panel Spawn Location

1. Run Xircuits and run a workflow. Verify that the output panel spawns at the bottom (default location)
2. Navigate to `.xircuits/config.ini`
3. Update the `splitMode. Options are split-bottom, split-top, split-right, split-left.
4. Rrerun another workflow. Verify that the new spawn location is what have been specified. 

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

@MFA-X-AI MFA-X-AI merged commit e26c5e9 into master Sep 29, 2023
8 checks passed
@MFA-X-AI MFA-X-AI deleted the fahreza/output-spawn-setting branch September 29, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant