winapi: Refactor GetDayOfWeek function #671
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #670, GetDayOfWeek() function had an unusual code style and did not behave well with clang-format.
The notation for this function was originally a copy paste of the "Keith" method from https://en.wikipedia.org/wiki/Determination_of_the_day_of_the_week.
This PR refactors the function to a more standard format. The functionality has been verified against the original wiki implementation with the below code .
I changed the function inputs to INTs are that is what the alogirthm calls for. This was technically a bug.