Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guarantee that src/plugin/schema.json is up-to-date #189

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Guarantee that src/plugin/schema.json is up-to-date #189

merged 3 commits into from
Dec 20, 2024

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Dec 20, 2024 •
edited
Loading

It should not be possible for src/plugin/schema.json to be different than schema/schema.json. By having the build script of the schema place the file under src/plugin, we guarantee this.

@psrpinto psrpinto self-assigned this Dec 20, 2024
@psrpinto psrpinto marked this pull request as ready for review December 20, 2024 15:11
@psrpinto psrpinto requested a review from ashfame December 20, 2024 15:11
@psrpinto psrpinto merged commit 58e893e into trunk Dec 20, 2024
3 checks passed
@psrpinto psrpinto deleted the build-schema-improvement branch December 20, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfame ashfame ashfame approved these changes

Assignees

@psrpinto psrpinto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psrpinto @ashfame