Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to start Chrome #17

Merged
merged 5 commits into from
Aug 26, 2024
Merged

Conversation

akirk
Copy link
Member

@akirk akirk commented Aug 21, 2024

Adds a new option so that you can decide which browser to use.

@akirk akirk requested a review from psrpinto August 21, 2024 14:42
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense!

Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this won't work currently because the watch only builds firefox

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be good to go now

@akirk akirk merged commit f7493d2 into simplify-directory-structure Aug 26, 2024
1 check passed
@akirk akirk deleted the add-chrome-option branch August 26, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants