Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify directory structure #15

Merged
merged 7 commits into from
Aug 21, 2024
Merged

Conversation

psrpinto
Copy link
Member

@psrpinto psrpinto commented Aug 20, 2024

The directory structure was unnecessarily complex and tied to being an extension. This PR simplifies it and brings our "app" to the root, so that it's clear that the app is not the extension, but that it can be shipped in an extension.

By this I mean that our app can also be shipped in another format, for example a webpage that displays the site to import on the left, and the "app" on the right.

This unlocks the possibility of developing in the web version, then shipping in the extension, because developing a web page has much better development experience than developing an extension. I will set that up in a future PR.

Before After
Screenshot 2024-08-20 at 16 26 50 Screenshot 2024-08-20 at 16 28 21

@psrpinto psrpinto self-assigned this Aug 20, 2024
@psrpinto psrpinto requested a review from akirk August 20, 2024 15:34
@psrpinto psrpinto marked this pull request as ready for review August 20, 2024 15:34
@psrpinto psrpinto changed the title simplify directory structure Simplify directory structure Aug 20, 2024
@akirk akirk force-pushed the simplify-directory-structure branch from 486ac09 to ebd0919 Compare August 21, 2024 12:56
Copy link
Member

@akirk akirk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works nicely, let's go with this!

@psrpinto psrpinto merged commit 2d5b15a into trunk Aug 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants