-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Readme.md with theme instructions. #51
base: trunk
Are you sure you want to change the base?
Conversation
I need to test if this actually work on Windows... |
I may be doing something wrong. If the path to theme review action is Then -I think that The error on Windows is still present:
|
The extra Try: |
I did already try with the extra --, the result is the same. Log from today:
|
I don't have the problem on my windows VM in both bash or powershell: Can you make sure of the following:
|
I'm not sure if we need this to work on your machine seeing that the |
Except I am not the only person experiencing these errors. I had to recommend another tester to place the theme in the folder manually. What are the minimum and or recommended versions of npm and node? |
Yep, definitely agree with that but this PR itself is not platform-specific. The problems you are experiencing are part of the wider windows issue mentioned in #18. What are the minimum and or recommended versions of npm and node?
|
NPM 6.14.13 |
As mentioned in #50, it isn't clear what should be done with the
test-theme
folder.I think it's easier if we explicitly instruct users to pass in the path for now.
Fixes #50.