Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change error type for License check error codes #772

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Change error type for License check error codes #772

merged 2 commits into from
Nov 6, 2024

Conversation

ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 6, 2024 •
edited
Loading

Will fix first part of #762

  • Change invalid_license to ERROR type
  • Similar for license_mismatch
  • Updated unit tests for the updated error type

@ernilambar ernilambar marked this pull request as ready for review November 6, 2024 06:00
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 6, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: davidperezgar <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar requested a review from swissspidy November 6, 2024 06:00
@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugin Review Issues owned by Plugin Review Team labels Nov 6, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 6, 2024
@davidperezgar davidperezgar merged commit 971ebf7 into trunk Nov 6, 2024
32 checks passed
@davidperezgar davidperezgar deleted the license-error-type branch November 6, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidperezgar davidperezgar davidperezgar approved these changes

@swissspidy swissspidy swissspidy approved these changes

@barrykooij barrykooij Awaiting requested review from barrykooij barrykooij is a code owner

@frantorres frantorres Awaiting requested review from frantorres frantorres is a code owner

@chriscct7 chriscct7 Awaiting requested review from chriscct7 chriscct7 is a code owner

Assignees
No one assigned
Labels
[Team] Plugin Review Issues owned by Plugin Review Team [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ernilambar @swissspidy @davidperezgar