-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
List View: fix appender size #68221
base: trunk
Are you sure you want to change the base?
List View: fix appender size #68221
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +17 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
Flaky tests detected in 58f2ed4. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12451235643
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
padding: 0; | ||
|
||
// TODO: Consider passing size="small" to the Inserter toggle instead. | ||
// Special dimensions for this button. | ||
&.block-editor-inserter__toggle { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, won't this result in a more specific selector, but with duplicate classname:
.list-view-appender .block-editor-inserter__toggle.block-editor-inserter__toggle
I'd expect a single use of the .block-editor-inserter__toggle
classname, and the extra specificity could come from using the other classes (.has-icon.is-next-40px-default-size
)
background-color: $gray-900; | ||
color: $white; | ||
margin: $grid-unit-10 0 0 $grid-unit-30; | ||
height: $button-size-small; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the var reuse 🙇
Related to #68155
What?
The list view appender is expected to be 24px in size, but due to the low specificity of the CSS selector it appears to have changed to 40px wide:
How?
As this comment says, ideally we should consider using
size="small"
prop instead of custom CSS, but for now I increased the specificity of the CSS selector and overridden it with a 24px size.I've also replaced some hard-coded values with SCSS variables.
Testing Instructions
Open the Navigation block's sidebar to see the size of the appender.
Note: As far as I know, the Navigation block's sidebar is the only place where the appender is displayed in the list view.
Screenshots or screencast