Skip to content

Commit

Permalink
Merge pull request #844 from WordPress/feature/ghactions-php-8.3-update
Browse files Browse the repository at this point in the history
  • Loading branch information
schlessera authored Dec 11, 2023
2 parents e62f563 + 5ac66e2 commit 12348aa
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ jobs:
strategy:
matrix:
# Lint against the high/low versions of each PHP major + nightly.
php: ['5.6', '7.0', '7.4', '8.0', '8.2', '8.3']
php: ['5.6', '7.0', '7.4', '8.0', '8.2', '8.3', '8.4']

name: "Lint: PHP ${{ matrix.php }}"
continue-on-error: ${{ matrix.php == '8.3' }}
continue-on-error: ${{ matrix.php == '8.4' }}

steps:
- name: Checkout code
Expand All @@ -40,15 +40,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-composer-dependencies
- name: Install Composer dependencies - normal
if: ${{ matrix.php != '8.3' }}
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

# For PHP "nightly", we need to install with ignore platform reqs.
- name: Install Composer dependencies - with ignore platform
if: ${{ matrix.php == '8.3' }}
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-req=php
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,18 +23,18 @@ jobs:
# Keys:
# - coverage: Whether to run the tests with code coverage.
matrix:
php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.3']
php: ['7.0', '7.1', '7.2', '7.3', '7.4', '8.0', '8.1', '8.2', '8.4']
coverage: [false]

include:
# Run code coverage on low/high PHP.
- php: '5.6'
coverage: true
- php: '8.2'
- php: '8.3'
coverage: true

name: "Test: PHP ${{ matrix.php }}"
continue-on-error: ${{ matrix.php == '8.3' }}
continue-on-error: ${{ matrix.php == '8.4' }}

steps:
- name: Checkout code
Expand All @@ -60,15 +60,15 @@ jobs:
# Install dependencies and handle caching in one go.
# @link https://github.com/marketplace/actions/install-composer-dependencies
- name: Install Composer dependencies - normal
if: ${{ matrix.php != '8.3' }}
if: ${{ matrix.php != '8.4' }}
uses: "ramsey/composer-install@v2"
with:
# Bust the cache at least once a month - output format: YYYY-MM.
custom-cache-suffix: $(date -u "+%Y-%m")

# For PHP "nightly", we need to install with ignore platform reqs.
- name: Install Composer dependencies - with ignore platform
if: ${{ matrix.php == '8.3' }}
if: ${{ matrix.php == '8.4' }}
uses: "ramsey/composer-install@v2"
with:
composer-options: --ignore-platform-req=php
Expand Down

0 comments on commit 12348aa

Please sign in to comment.