-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-Platform GUI API [v5] #106
Draft
WolfyScript
wants to merge
117
commits into
v5.0.0
Choose a base branch
from
v5-gui-api-rewrite
base: v5.0.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed ButtonInteractionResult to InteractionResult
* This should allow for access to NBT etc. of stacks in common implementations in the future.
* Note this is more limited than v4, because other types of inventories may contain slots that do not act like normal container slots.
* #getCurrentWindowState * #getRenderContext(UUID) * #getRouter
These interfaces are used to detect used variables, like signals, at runtime.
* The WindowRenderer is now instantiated for each GuiViewManager and constructs the initial state, including signals and components. After that, components are only updated via signals. * Slots are stored inside the ComponentBuilder now. * Add SignalledObject that can be linked to Signals * Removed old unused code * Removed WindowState and ComponentState
* this function requires a ReactiveResult to be returned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current GUI API is only available on Spigot.
There should be a cross-platform (Spigot, Sponge, Paper) API, which then would make it easier to create cross-platform inventory GUIs.
Plus, the current GUI is pretty much hardcoded and not customizable outside Java classes.
The new system will be build using a functional style, meaning there is no need to create custom implementations for GUI Components and menus.
All is done via builders and callback lambda functions.
API:
Basic interface structure
Basic common Implementation
Component Builders
Create a builder with a common implementation, then access it on each platform to extend it.
Config
Implementation