Improved and updated data component wrapper #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix factories order of initialisation
(Sponge, Spigot not fully implemented yet)
* Locks are no longer pure strings * Spigot has apparently no API for the new lock format (yet?) * Need to update to new Sponge API for support. Mark as TODO for now. * This adds a new Lock object to future-proof it
* The textures de-/serialization still needs work
* They are not implemented yet, but this way they can be tested one after another
This abstracts the Sponge ItemStackSnapshot and will have similar behaviour on Spigot
* Add missing properties to components * Add missing components * Add components to provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks the whole DataKey system that wraps and convert platform specific data component APIs.
This PR defines the data keys, that convert these platform types to a common API, and makes sure they are registered on each platform.
Most data keys are yet to be implemented, either because conversions need more work, or a platform does not provide an API to access the data component. e.g. there's no API for Lock components on Spigot.
A List about the current state of the component implementation can be found here in the wiki