optimize ingester data cleanup when a tenant is deleted #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: junot <[email protected]>
benjaminhuo
reviewed
Jul 26, 2023
pkg/api/monitoring/v1alpha1/types.go
Outdated
| type IngesterTenantStatus struct { | ||
| Name string `json:"name"` | ||
| // true represents that the tenant has been moved to other ingester but may left tsdb data in this ingester. | ||
| Legacy bool `json:"legacy"` |
There was a problem hiding this comment.
Suggested change
| Legacy bool `json:"legacy"` | |
| Obsolete bool `json:"obsolete"` |
benjaminhuo
approved these changes
Jul 26, 2023
Signed-off-by: junot <[email protected]>
|
@wanjunlei pls also take a look |
benjaminhuo
approved these changes
Jul 26, 2023
benjaminhuo
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a tenant is added or deleted, only the ingester associated with it will restart.
This pr may be able to fix the issue #284, or at least reduce its frequency.