fix(DiffViewer & ArticleViewer): handle moved articles using MediaWik… #6072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…i page ID - Added "crossCheckArticleTitle" function to verify and update article titles and URLs using the MediaWiki API based on the page ID. - Introduced "UPDATE_ARTICLE_TITLE_AND_URL" action in the reducer to update article titles and URLs in the Redux store when article title is changed. - Modified "fetchMissingArticleDetails" of Article used by DiffViewer & ArticleViewer to pass article.title and article.mw_page_id for title verification. - Updated "fetchArticleDetails" to integrate "crossCheckArticleTitle" for dynamic title validation and updates before fetching article details. - Enhanced handling of moved articles by verifying and updating titles via MediaWiki API by using "crossCheckArticleTitle" in ArticleViewer.
Abishekcs
force-pushed
the
fix/diffviewer-handle-moved-articles
branch
from
3a99736 to
f4a8315
Compare
|
I don't know why the build is failing for the test article_viewer_spec.rb. It’s passing for me locally.😅 2024-12-22.18-19-58.mp4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6056
What this PR does
This PR addresses an issue where the
DiffViewerandArticleViewercomponents did not handle moved articles correctly, resulting inerrorsforDiffViewerandCould not fetch authorship data: Requested page not found. [404]forArticleViewer.Fix
Check the current article title by fetching it from the Wikipedia API using the article's page ID. If it matches, do not update the Redux store; otherwise, update the title and URL for the respective article.
NOTE: The article title will only be cross-checked for articles when the user wants to view the "Current Version w/ Authorship Highlighting" or "Show Cumulative Changes."
Screenshots
Before:
Before.mp4
After:
After.mp4