Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix:restored removed article to available articles #6060

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

shishiro26
Copy link
Contributor

NOTE: Please review the pull request process before opening your first PR: https://github.com/WikiEducationFoundation/WikiEduDashboard/blob/master/CONTRIBUTING.md#pull-request-process

What this PR does

This PR restores both self-assigned and admin-assigned articles back to the pool of available articles.
I have written a test case for the controller to ensure that the changes work as expected.

Screenshots

After:
https://github.com/user-attachments/assets/db77ecb3-734d-4693-94d2-cfd235297c90

Open questions and concerns

With this change, when removing an article, a dialog appears with the message: "Are you sure you want to delete this program?"

  • Do we need to modify the dialog message to reflect the new functionality?

#5549

@shishiro26 shishiro26 marked this pull request as draft December 13, 2024 14:27
@shishiro26
Copy link
Contributor Author

In this PR, I have added Ruby test cases for the unclaim method in the AssignmentsController.

The scenarios covered are as follows:

  1. When the article is assigned to the user by the admin:
  2. When the article is assigned to the user by the admin:
  3. When the article is self-assigned:

@shishiro26 shishiro26 marked this pull request as ready for review December 23, 2024 15:45
@shishiro26
Copy link
Contributor Author

@ragesoss the test is passing locally in my system
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant