Code simplifications and tidying #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Jun 17, 2024
| @@ -59,8 +65,9 @@ class QuadratureRule | |||
| /// Return the number of quadrature points per entity | |||
| std::size_t num_points(int i) const; | |||
|
|
|||
| /// Return the topological dimension of the quadrature rule | |||
| std::size_t tdim() const { return _tdim; }; | |||
| /// Topological dimension of the quadrature rule | |||
There was a problem hiding this comment.
I guess you can rephrase this to the dimension of the quadrature points i.e. x=x_i, i=0,…,tdim-1
jorgensd
reviewed
Jun 17, 2024
|
|
||
| private: | ||
| // What is this? |
There was a problem hiding this comment.
Cell type associated with the quadrature rule
jorgensd
reviewed
Jun 17, 2024
| dolfinx::mesh::CellType _cell_type; | ||
|
|
||
| std::size_t _tdim; | ||
|
|
||
| // What is this? |
There was a problem hiding this comment.
Maximum polynomial degree that will be integrated exactly.
jorgensd
reviewed
Jun 17, 2024
| int _degree; | ||
|
|
||
| // What is this? |
There was a problem hiding this comment.
What quadrature rule to use. See available rules in Basix
jorgensd
reviewed
Jun 17, 2024
| basix::quadrature::type _type; | ||
|
|
||
| // What is this? |
There was a problem hiding this comment.
Dimension of the sub-entities of the cell that the quadrature rule is generated for
jorgensd
reviewed
Jun 17, 2024
jorgensd
reviewed
Jun 17, 2024
Co-authored-by: Jørgen Schartum Dokken <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.