Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set proper unit for "Score" Metric #311

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Set proper unit for "Score" Metric #311

merged 2 commits into from
Sep 12, 2023

Conversation

camillobruni
Copy link
Contributor

  • Use "score" as unit
  • Format benchmark-runner.mjs

@camillobruni camillobruni added the major change A change with major implications on benchmark results or affect governance policy label Sep 11, 2023
@julienw
Copy link
Contributor

julienw commented Sep 11, 2023 •
edited
Loading

The formatting brings a conflict, it might be easier to reformat in a separate patch.

Is it really a major change ? :-)

julienw
julienw approved these changes Sep 11, 2023
View reviewed changes
Copy link
Contributor

@julienw julienw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it true to say that it's used in the json only? I don't see where it's used otherwise.
If it's in the json only this works for me, otherwise I think I'd use the empty string instead.

@camillobruni camillobruni added trivial change A change that doesn't affect benchmark results and removed major change A change with major implications on benchmark results or affect governance policy labels Sep 12, 2023
@camillobruni
Copy link
Contributor Author

yes this is only affecting the json

@camillobruni camillobruni merged commit b104525 into WebKit:main Sep 12, 2023
4 checks passed
@camillobruni camillobruni deleted the 2023-09-11_use_proper_metric_unit branch September 12, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julienw julienw julienw approved these changes

@rniwa rniwa rniwa approved these changes

Assignees
No one assigned
Labels
trivial change A change that doesn't affect benchmark results
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@camillobruni @julienw @rniwa