New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor AppDocumentation #18

Closed

antonvolkoff wants to merge 3 commits into WeTransfer:master from antonvolkoff:master

antonvolkoff commented Aug 20, 2018

The first step to making #17 a reality.

Changes:

I have removed all .respond_to? checks from AppDocumentation class by adding the method to_tagged_markdown to all classes that used to build up documentation.
Removed so redundant code from lib/apiculture.rb
Defined some constants in AppDocumentation instead of "magic" text
Extracted TaggedMarkdown into a separate file as its now used by multiple classes

antonvolkoff added 3 commits

August 20, 2018 21:48


          Remove redundant code

c6fbe11


          Refactor AppDocumentation class

10ce043


          Rename .to_markdown_slice to .to_tagged_markdown

d8832be

antonvolkoff closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet