Share y axis between "density" and "colours used" plot, but not main plot #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardchalstrey1
changed the title
Test changes choroplethThe one without the extent has the same change Old
New
Test changes scatterThe no bin one still looks bad (see top comment) Old
New
|
|
@rolyp in the interest of time I'm going to merge this and focus on the remaining minimal completion goals in the remaining time I have before xmas leave |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does
Fixes #64
The scatter plot tests are updated because they now have the correct y axis on the main plots.
The choropleth tests are also updated however, because the y ticks on the "Colours used" plots are now different, see screenshots below.
Also updated to python 3.9.9 because GH actions was having a problem with 3.9.8 (as seen in this issue) and upgrading to 3.9.9 seems to work fine for our purposes - I updated the poetry files to match.
This PR does not
Contain a solution for #63
The
expected_meta_hist_scatterplot_bin_Falsetest is still showing a faulty plot, because the "Colours used" plot is still missing for bin being set to false. I have updated it here anyway, since it is now coming out different from before. @rolyp I'll aim to work on a separate branch for #76 and #63 next since these issues related to the colour scale are related, but I think it makes sense to merge these changes first.Also whilst this change makes the y ticks for the colours used plot a little neater, it doesn't complete #58