Make DistanceDither the base material for almost all meshes in the game
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default all entities should fade into the fog. Otherwise occluded entities actually become visible behind faded terrain.
There are "better" ways to do this, by specializing the render pipeline to add my own global uniforms, but there is not currently an ergonomic way to do that, and it almost certainly won't be noticeable to copy the fog parameters to a few assets each frame. The only way I could see it mattering is if somehow change detection causes more work in the
Rendersub-app. Even then, it likely won't show up until a lot more materials are added. I also started profiling things on nightly, so I will be able to tell if it becomes a problem.