ASUB-8954 Fixing style (#2282)

Fixing style, attending feedback and fixing typo
WPMedia · Dec 18, 2024 · 2ff94d5 · 2ff94d5
1 parent 3028ccc
commit 2ff94d5
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 6 deletions.
diff --git a/blocks/identity-block/_index.scss b/blocks/identity-block/_index.scss
@@ -219,6 +219,11 @@
 				@include scss.block-properties("social-sign-on-button-container-apple-custom");
 			}
 
+			&__sso{
+				@include scss.block-components("social-sign-on-button-container-apple-sso");
+				@include scss.block-properties("social-sign-on-button-container-apple-sso");
+			}
+
 			@include scss.block-components("social-sign-on-button-container-apple");
 			@include scss.block-properties("social-sign-on-button-container-apple");
 		}

diff --git a/blocks/identity-block/components/social-sign-on/_children/AppleSignIn.jsx b/blocks/identity-block/components/social-sign-on/_children/AppleSignIn.jsx
@@ -31,7 +31,7 @@ function AppleSignIn({ customButtons, socialSignOnIn, className, oidcClients = [
 	return (
 		<div
 			data-testid="apple-sign-in-button"
-			style={{ width: '100%' }}
+			className={`${className}__Apple__sso`}
 		>
 			<Button
 				id="apple-btn"

diff --git a/blocks/identity-block/features/social-sign-on/default.jsx b/blocks/identity-block/features/social-sign-on/default.jsx
@@ -131,7 +131,7 @@ SocialSignOnBlock.propTypes = {
 				"Used when we want to hide the ---OR--- divider",
 		}),
 		customButtons: PropTypes.bool.tag({
-			name: "Custom Facebook/Gooogle/Apple buttons",
+			name: "Custom Facebook/Google/Apple buttons",
 			defaultValue: true,
 			description:
 				"Render a custom Facebook/Google/Apple buttons or the ones provided by Facebook, Google, and Apple.",

diff --git a/blocks/identity-block/themes/news.json b/blocks/identity-block/themes/news.json
@@ -863,6 +863,16 @@
 			"desktop": {}
 		}
 	},
+	"social-sign-on-button-container-apple-sso":{
+		"styles": {
+			"default": {
+				"inline-size": "100%",
+				"justify-content": "center", 
+				"display": "flex"
+			},
+			"desktop": {}
+		}
+	},
 	"social-sign-on-dividerWithText": {
 		"styles": {
 			"default": {

diff --git a/blocks/subscriptions-block/features/checkout/_children/Review/index.jsx b/blocks/subscriptions-block/features/checkout/_children/Review/index.jsx
@@ -263,7 +263,7 @@ const ReviewOrder = ({
 					result = await stripe.confirmCardPayment(
 						clientSecret,
 						{
-							payment_method: event.paymentMethod.id,
+							payment_method: event?.paymentMethod?.id,
 						},
 						{
 							handleActions: false,
@@ -274,7 +274,7 @@ const ReviewOrder = ({
 					result = await stripe.confirmCardSetup(
 						clientSecret,
 						{
-							payment_method: event.paymentMethod.id,
+							payment_method: event?.paymentMethod?.id,
 						},
 						{
 							handleActions: false,
@@ -298,7 +298,7 @@ const ReviewOrder = ({
 				Sales.finalizePayment(
 					orderNumber,
 					stripeIntents?.paymentMethodID,
-					result.paymentIntent.id,
+					result?.paymentIntent?.id,
 					null,
 					recaptchaStored || captchaToken,
 				)
@@ -314,7 +314,7 @@ const ReviewOrder = ({
 				Sales.finalizePayment(
 					orderNumber,
 					stripeIntents?.paymentMethodID,
-					result.setupIntent.id,
+					result?.setupIntent?.id,
 					null,
 					recaptchaStored || captchaToken,
 				)