Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Paths and Pins #274

Merged
merged 1 commit into from
Jan 19, 2024
Merged

Fix Paths and Pins #274

merged 1 commit into from
Jan 19, 2024

Conversation

blinkdog
Copy link
Contributor

  • Modifies collabssh so that it invokes sshproxy.sh without requiring that the current directory be on one's PATH.
  • Adds a lower bound on the wipac-rest-tools requirement; use of ArgumentHandler requires >=1.6.0
    • Pip was choosing from the 1.5.x series, which will no longer work.

@blinkdog blinkdog requested a review from dsschult January 18, 2024 23:02
@blinkdog blinkdog self-assigned this Jan 18, 2024
@dsschult
Copy link
Contributor

It would be interesting to see the log from pip where it was choosing the 1.5.x series, and why it was doing so.

@blinkdog
Copy link
Contributor Author

pip-install-output.txt

It's interesting because it picks 1.6.0 at first, then after requests-futures it looks for compatible (~1.5.x) versions:

Collecting requests-futures (from wipac-rest-tools->lta==0.42.0)
  Downloading requests_futures-1.0.1-py2.py3-none-any.whl.metadata (12 kB)
INFO: pip is looking at multiple versions of wipac-rest-tools to determine which version is compatible with other requirements. This could take a while.
Collecting wipac-rest-tools (from lta==0.42.0)
  Downloading wipac_rest_tools-1.5.3-py3-none-any.whl.metadata (6.1 kB)
  Downloading wipac_rest_tools-1.5.2-py3-none-any.whl.metadata (6.1 kB)

@blinkdog blinkdog merged commit 7c5cd53 into master Jan 19, 2024
27 checks passed
@blinkdog blinkdog deleted the small-fixes branch January 19, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants