Fixes #151 - Define a "ch-ua-high-entropy-values" permission policy #373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The allows top-level sites to restrict which third-party sites are able to receive high-entropy ua client hint data, or even disable itself from collection of any high-entropy ua client hint data.
miketaylr
changed the title
miketaylr
commented
Dec 20, 2024
|
|
||
| 1. Let |p| be a [=a new promise=] created in the [=current realm=]. | ||
|
|
||
| 2. If the [=user agent=] decides one or more values in |hints| should not be returned, then [=reject=] and return |p| with a "{{NotAllowedError}}". |
There was a problem hiding this comment.
This has never been implemented, FWIW (at least not in Chromium).
yoavweiss
reviewed
Dec 20, 2024
| @@ -338,7 +338,7 @@ brand of the browser to the user. These messages often also include the platform | |||
| order to make sure the user knows which device is in question. | |||
|
|
|||
| Since such messaging doesn't require any server-side adaptation, it's better for this case to use | |||
| the `userAgentData.getHighEntropyData()` method in order to retrieve the required information. | |||
| the `userAgentData.getHighEntropyValues()` method in order to retrieve the required information. | |||
There was a problem hiding this comment.
Is this rename web compatible?
There was a problem hiding this comment.
Good question. I was also a bit confused when I saw that :)
Turns out we just had 2 instances of the wrong name in the use-cases section (🙈). Not sure when that crept in, or if getHighEntropyData was the original name way back when. But we're not actually changing any IDL - getHighEntropyValues is the thing we shipped (and continue to ship).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The allows top-level sites to restrict which third-party sites are able to receive high-entropy ua client hint data, or even disable itself from collection of any high-entropy ua client hint data.
Preview | Diff