Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for import map composition and a "cascading" composition implementation #167

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

add tests for import map composition and a "cascading" composition implementation #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
e5b5eec
add tests for composition and a "cascading" composition implementation
michaelficarra Jul 18, 2019
3631bc6
fix linting (though the code is arguably worse now)
michaelficarra Jul 24, 2019
c82b348
switch maps from URLs to strings
michaelficarra Aug 2, 2019
e7b5f34
deduplicate logic between resolver and composer
bakkot Aug 8, 2019
bfe8382
empty commit to rerun CI
bakkot Aug 8, 2019
08d220c
Update reference-implementation/__tests__/composition.js
michaelficarra Aug 15, 2019
ccaf0c0
Update reference-implementation/__tests__/composition.js
michaelficarra Aug 15, 2019
4c1136f
remove JSON round-trip
michaelficarra Aug 15, 2019
4555be2
inline JSON representation of input import maps in composition tests
michaelficarra Aug 15, 2019
00cf730
add comment and parameter default for composition test helper function
michaelficarra Aug 15, 2019
b7cfa0f
different representations of URLs
michaelficarra Aug 15, 2019
7c3e1c1
move console warning out of tryURLLikeSpecifierParse
michaelficarra Aug 15, 2019
0e64b9e
assert warnings
michaelficarra Aug 15, 2019
6be838f
assume resolve's scriptURL parameter is a URL
michaelficarra Aug 15, 2019
7c621af
add another test for maps not cascading to themselves
michaelficarra Aug 16, 2019
9977979
add another test for merge-within-scopes strategy (taken from #153)
michaelficarra Aug 16, 2019
fd7d8d3
composition warns if there's a non-URL in the RHS of the result
michaelficarra Aug 16, 2019
47558af
add another test for bare specifier stripping
michaelficarra Aug 16, 2019
e07afd0
bad -> nonURL
michaelficarra Aug 16, 2019
976c90c
Change duplicate test names
domenic Aug 23, 2019
de67f8d
Always use std:blank and variable prefix
domenic Aug 23, 2019
b5bb539
Checkpoint: spec concatenating
domenic Aug 28, 2019
2a94ea6
Checkpoint: spec parsing a specifier
domenic Aug 28, 2019
c0c5772
Checkpoint: specify "get the fallbacks"
domenic Aug 28, 2019
785a235
Spec new "resolve"
domenic Aug 29, 2019
43b564a
Update parser spec
domenic Aug 29, 2019
7a791d4
Properly make the URL types flow through
domenic Aug 29, 2019
ace007a
100% coverage
domenic Aug 29, 2019
842a995
Move composing spec section after parsing
domenic Aug 29, 2019
22f5238
More rearranging
domenic Aug 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
/reference-implementation/node_modules/
/reference-implementation/coverage/
/out/
/spec.html
/deploy_key
1 change: 0 additions & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ node_js:
before_install:
- cd reference-implementation
script:
- npm run lint
- npm test
- cd .. && bash ./deploy.sh

Expand Down
Loading