Select All #142
Closed
Select All #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This works for ctrl-A on ALL platforms, if we want it to work with cmd-A on MAC, I'll need to add some less-than-elegant logic. |
|
This selects all images that have already been loaded in the current filtered view, which I think is the practical way to implement this, but may not meet user expectations. #152 should hit some of the use case for this. I think it would be best if this particular feature would only select the images that are visible in the browser and we should implement #152 to support that other use case. |
|
@joefutrelle Based on your last comment, does this one need further changes? There's a merge conflict, but its not much of a conflict and get be resolved easily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.