Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement dylib parsing #43

Merged
merged 9 commits into from
Oct 7, 2023
Merged

feat: implement dylib parsing #43

merged 9 commits into from
Oct 7, 2023

Conversation

latonis
Copy link
Contributor

@latonis latonis commented Sep 29, 2023 •
edited
Loading

Implemented dylib parsing

  • added tests as well
  • rustfmt ran on macho module directory
  • rustfmt.toml had an invalid value of "max", changed to "Max"

TommYDeeee
TommYDeeee reviewed Oct 2, 2023
View reviewed changes
yara-x/src/modules/macho/mod.rs Show resolved Hide resolved
yara-x/src/modules/macho/mod.rs Show resolved Hide resolved
yara-x/src/tests/mod.rs Outdated Show resolved Hide resolved
@TommYDeeee
Copy link
Contributor

Thank you for this addition! I have left few suggestions. Don't take them as granted, just something to think about

TommYDeeee
TommYDeeee reviewed Oct 5, 2023
View reviewed changes
yara-x/src/tests/mod.rs Outdated Show resolved Hide resolved
TommYDeeee
TommYDeeee approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@TommYDeeee TommYDeeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this addition

@plusvic plusvic merged commit fd70085 into VirusTotal:main Oct 7, 2023
23 checks passed
@latonis latonis mentioned this pull request Oct 9, 2023
Closed
@latonis latonis deleted the dylib-parsing branch November 25, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommYDeeee TommYDeeee TommYDeeee approved these changes

@plusvic plusvic plusvic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@latonis @TommYDeeee @plusvic