feat: add support for --module-data option in scan command
#183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
plusvic
reviewed
Aug 30, 2024
plusvic
reviewed
Aug 30, 2024
plusvic
reviewed
Sep 4, 2024
plusvic
reviewed
Sep 5, 2024
plusvic
reviewed
Sep 5, 2024
cli/src/commands/dump.rs
Outdated
| @@ -22,6 +22,7 @@ enum SupportedModules { | |||
| Elf, | |||
| Pe, | |||
| Dotnet, | |||
| Eml, | |||
There was a problem hiding this comment.
yep, should not be there
plusvic
changed the title
--module-data option in scan command
plusvic
added a commit
that referenced
this pull request
Sep 5, 2024
Adds support for the `--module-data` option. This required some changes in the API, particularly the introduction of two new methods to `Scanner`. --------- Co-authored-by: Victor M. Alvarez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pre-existing code did not support the additional input (the -x flag input) necessary for some modules. Hence a modification of the relevant part of the code was made to enable passing a more complex struct to the
#[module_main]function (as opposed to just a single_: &[u8]input argument).The implementation itself should be in line with what was discussed with @TommYDeeee