feat: Implement tag printing. #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a -t argument to the scan command which will print the tags of matching rules. One thing I realized (and this is also true for metadata) is that if there is no tags we are still including them in the JSON (just as an empty list). When we print in text mode we have checks if the tags are empty and skipping them if so. I'm open to changing the JSON output so that we do not include a "meta" and "tags" key if they are empty.
This commit implements the -t flag which allows you to filter matched rules by tag.
|
I also added in tag filtering. It currently works like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a -g argument to the scan command which will print the tags of matching rules.
One thing I realized (and this is also true for metadata) is that if there is no tags we are still including them in the JSON (just as an empty list). When we print in text mode we have checks if the tags are empty and skipping them if so.
I'm open to changing the JSON output so that we do not include a "meta" and "tags" key if they are empty.