Run extra tests for main supported JVM versions #3375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Gedochao
commented
Dec 17, 2024
•
Gedochao
commented
- just some extra tests to ensure the CLI is compatible with all the main Java versions it should be compatible with.
- relevant to add JDK 23 to build tool table scala/docs.scala-lang#3082
Gedochao
force-pushed
the
maintenance/test-java-23
branch
from
8a3c41f to
1a5c065
Compare
Gedochao
force-pushed
the
maintenance/test-java-23
branch
from
1a5c065 to
c1bd77a
Compare
Gedochao
changed the title
Gedochao
force-pushed
the
maintenance/test-java-23
branch
2 times, most recently
from
b0d4619 to
a57e90c
Compare
…nstallation's `scala` script
Gedochao
force-pushed
the
maintenance/test-java-23
branch
from
a57e90c to
2c203af
Compare
tgodzik
approved these changes
Dec 20, 2024
|
|
||
| trait RunJdkTestDefinitions { _: RunTestDefinitions => | ||
| def javaIndex(javaVersion: Int): String = | ||
| // TODO just passing the version number on arm64 should be enough, needs a fix in cs |
| } | ||
| } | ||
|
|
||
| if (!Properties.isWin || !useScalaInstallationWrapper) // TODO make this pass on Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.