Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry generating Windows launchers in the generate-native-image.sh script directly, rather than the entire CI step #3350

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Dec 5, 2024

A follow-up to #3349
Although the CI step retry does work, it seems our script assumes a clean workspace, so we need to surgically retry just the part that times out, rather than the whole step, it seems.

Currently, the retries fail with:

(...)
Warning: Attempt 1 failed. Reason: Child_process exited with error code 1
Launching Mill as sub-process ...
Initial Java home C:\Users\runneradmin\AppData\Local\Coursier\cache\arc\https\github.com\graalvm\graalvm-ce-builds\releases\download\vm-22.3.1\graalvm-ce-java17-windows-amd64-22.3.1.zip\graalvm-ce-java17-22.3.1
1 targets failed
ci.copyJvm java.nio.file.FileAlreadyExistsException: D:\a\scala-cli\scala-cli\jvm
    java.base/sun.nio.fs.WindowsFileCopy.copy(WindowsFileCopy.java:124)
    java.base/sun.nio.fs.WindowsFileSystemProvider.copy(WindowsFileSystemProvider.java:284)
    java.base/java.nio.file.Files.copy(Files.java:1305)
    os.copy$.copyOne$1(FileOps.scala:200)
    os.copy$.apply(FileOps.scala:204)
    millbuild.build$ci$.$anonfun$copyJvm$2(build.sc:1948)
Warning: Attempt 2 failed. Reason: Child_process exited with error code 1
(...)

Example failure: https://github.com/VirtusLab/scala-cli/actions/runs/12177547205/job/33965654304#step:5:302

@tgodzik was likely right in #3349 (comment) 😩

@Gedochao Gedochao force-pushed the maintenance/fix-generate-windows-launcher-retry branch from 45024e8 to 20fc1d8 Compare December 5, 2024 11:10
…script directly, rather than the entire CI step
@Gedochao Gedochao force-pushed the maintenance/fix-generate-windows-launcher-retry branch from 20fc1d8 to 2d4c845 Compare December 5, 2024 11:21
@Gedochao Gedochao marked this pull request as ready for review December 6, 2024 09:26
@Gedochao Gedochao merged commit 1e3746b into VirtusLab:main Dec 6, 2024
78 checks passed
@Gedochao Gedochao deleted the maintenance/fix-generate-windows-launcher-retry branch December 6, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants