Fix commas being treated as using directives value separators & deprecate using them with whitespace
#3333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gedochao
force-pushed
the
update/using_directives-1.1.2
branch
3 times, most recently
from
0fa4c34 to
1ae6722
Compare
Gedochao
force-pushed
the
update/using_directives-1.1.2
branch
from
358244a to
1595b20
Compare
Gedochao
changed the title
using_directives to 1.1.2using directives value separators & deprecate using them with whitespace
Gedochao
force-pushed
the
update/using_directives-1.1.2
branch
4 times, most recently
from
6feb16b to
3a293e0
Compare
…e separators on their own, and being deprecated otherwise
- get rid of unnecessary commas and double quote escapes - bump versions where applicable - misc typo fixes & tweaks
…ommas and double quote escapes
…: get rid of unnecessary commas and double quote escapes
…cessary commas and double quote escapes
- get rid of unnecessary commas and double quote escapes - fix the `publish setup` sub-command to only add double quotes when a value contains whitespace chars - fix the `fix` sub-command to only add double quotes when a value contains whitespace chars
…sary commas and double quote escapes
Gedochao
force-pushed
the
update/using_directives-1.1.2
branch
from
3a293e0 to
21ff792
Compare
Gedochao
added
the
needs-minor-release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3282
NOTE: these are breaking changes affecting using directives syntax.
It's technically a fix + deprecation, but it is not impossible for existing builds to break.
For example, where
//> using scala 2.13,3Used to mean that Scala is set to 2.13 and 3 for cross-builds, it will now mean Scala is set to
2.13,3, which is not a valid version and will produce an error.The valid syntax for the same would now be:
//> using scala 2.13 3The fix itself is contained in the
using_directivesbump to 1.1.2:Specifically, it's this change:
What this PR does:
using_directivesto 1.1.2,) as separators without whitespace is no longer supported (the comma will now be treated as part of the value),) with a following whitespace as separator gets deprecated and will produce a warningpublish setupandfixsub-commands to use the latest syntax