Small corrections for gcp cloudrun example

[lbialy]

No description provided.

[lbialy]

It was for me to make this example work at all.

…

On Mon 26. Feb 2024 at 10:23, Paweł Prażak ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In examples/gcp-cloudrun/README.md <#405 (comment)>: > ```bash + gcloud auth application-default login # this is required for pulumi to reach GCP this is covered under prerequisites but we can mention it here as well ;) the thing is this is only one of the ways to authenticate to gcp, so it might be required, and probably will for newcommers — Reply to this email directly, view it on GitHub <#405 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBVNUREQM2IEJGXSCZ7O23YVRIA7AVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBQGM2DKNRUHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pawelprazak]

thank you, had some questions

[lbialy]

The fuck? I did uncomment it. Uh, let me fix this.

…

On Mon 26. Feb 2024 at 10:24, Paweł Prażak ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In examples/gcp-cloudrun/infra/project.scala <#405 (comment)>: > @@ -1,6 +1,6 @@ //> using scala "3.3.1" //> using options -Werror -Wunused:all -Wvalue-discard -Wnonunit-statement -//> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2" +///> using plugin "org.virtuslab::besom-compiler-plugin:0.2.2" if we are disabling it why not remove instead of commenting out? — Reply to this email directly, view it on GitHub <#405 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBVNUTTE4JWPNWMICTDF3DYVRIEZAVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMBQGM2DQMBTHE> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pawelprazak]

We can try to bump scala-cli version and see if it resolves the JVM version clash.

[lbialy]

Won't help. I'll remove jdk21 changes.

…

On Wed 28. Feb 2024 at 09:36, Paweł Prażak ***@***.***> wrote: We can try to bump scala-cli version and see if it resolves the JVM version clash. — Reply to this email directly, view it on GitHub <#405 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACBVNUWQGKGUVWNQCEGAJI3YV3UCRAVCNFSM6AAAAABDZZ523OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRYGQ3TOOBVGA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[pawelprazak]

Rebased on main