Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated docs for testing and adding primary variables (Thanks David a… #294

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

RoryBarnes
Copy link
Collaborator

…nd Sam!)

Proposed changes

Describe your changes here to communicate to the maintainers the value of this pull request (PR). If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your PR introduce to VPLanet?
Put an x in the boxes that apply

  • Bugfix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • New module (non-breaking change that adds a new module)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of the steps that are necessary before merging your PR.

  • I have added tests that prove my fix is effective or that my feature works
  • I have adhered to the Style or run the clang format code shown here
  • I have added necessary documentation (if appropriate)
  • I have run Valgrind on new tests to ensure no errors were found
  • (Optional) I have added an example showcasing the new change

Further comments

If this is a relatively large or complex change, explain why you chose the solution you did, what alternatives you considered, or anything else you believe to be relevant.

Copy link

Test Results

19 130 tests   19 114 ✅  3m 35s ⏱️
     1 suites       0 💤
     1 files        16 ❌

For more details on these failures, see this check.

Results for commit c0b2efb.

Copy link

github-actions bot commented Jun 21, 2024

Test Results

19 130 tests   19 114 ✅  4m 4s ⏱️
     1 suites       0 💤
     1 files        16 ❌

For more details on these failures, see this check.

Results for commit c0b2efb.

♻️ This comment has been updated with latest results.

@RoryBarnes RoryBarnes merged commit 7a87a63 into main Jun 21, 2024
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant