Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ BLS #1205

Merged
merged 16 commits into from
Dec 7, 2024
Merged

✨ BLS #1205

merged 16 commits into from
Dec 7, 2024

Conversation

Vectorized
Copy link
Owner

Description

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized Vectorized marked this pull request as ready for review December 6, 2024 01:32
Copy link

github-actions bot commented Dec 7, 2024

Gas Snapshot Comparison Report

Generated at commit : a0e3608, Compared to commit : 86b922d

Contract Name Test Name Main Gas PR Gas Diff
LibBytesTest testDirectReturn() 9159 - -
testSliceCalldata() 3109 3021 -88
test__codesize() 6790 3976 -2814
SafeTransferLibTest testApproveWithRetry() 789995 789930 -65
testPermit2() 90134 90118 -16
testPermit2AnythingWithNonContractReverts() 124716 124738 22
testSimplePermit2AndPermit2TransferFrom() 1139584 1139620 36
testTotalSupplyQuery() 27280 - -
testTransferFromWithMissingReturn() 587800 577939 -9861
testTransferFromWithReturnsFalseReverts() 554017 544136 -9881
testTransferFromWithReturnsTooLittleReverts() 553913 543931 -9982
testTransferFromWithReturnsTooMuch() 588432 578551 -9881
testTransferFromWithRevertingReverts() 546619 536738 -9881
testTransferFromWithStandardERC20() 586646 576767 -9879
testTransferWithMissingReturn() 574298 564440 -9858
testTransferWithNonContractReverts() 6886 6908 22
testTransferWithReturnsFalseReverts() 551075 541274 -9801
testTransferWithReturnsTooLittleReverts() 550671 541097 -9574
testTransferWithReturnsTooMuch() 574873 565011 -9862
testTransferWithRevertingReverts() 550925 541065 -9860
testTransferWithStandardERC20() 575018 565156 -9862
test__codesize() 69219 68521 -698
TimelockTest test__codesize() 19555 19492 -63

@Vectorized Vectorized merged commit bb3dc45 into main Dec 7, 2024
11 checks passed
@Vectorized Vectorized deleted the bls branch December 9, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant