-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IPFSのupload先変更:NFT.Storage → Pinata #142
IPFSのupload先変更:NFT.Storage → Pinata #142
Conversation
meage masger to feature/IPFS-optionalparametors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NFT.storageのnpm packageを削除して下さい
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
一点コメントしましたが、他はLGTMです
as使ったところは本当に必要か最後にチェックしといてください
src/storage/ipfs/upload.ts
Outdated
this.client = new NFTStorage({ token: ipfsNftStorageKey }); | ||
const pinataEndpoint = "https://api.pinata.cloud/pinning/pinFileToIPFS"; | ||
|
||
function isNode() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
isNodeとかrunningOnBrowserとか(いっぱいあったはず) envUtil
的なものに切出してください
Pinata
https://www.pinata.cloud/
https://docs.pinata.cloud/introduction