Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPFSのupload先変更:NFT.Storage → Pinata #142

Merged
merged 21 commits into from
Jun 3, 2024

Conversation

Huzitatuguharu
Copy link
Contributor

@Huzitatuguharu Huzitatuguharu commented May 9, 2024

@Huzitatuguharu Huzitatuguharu changed the title WIP:add optional parameter to the managedCreateTokenForIPFS method. managedCreateTokenForIPFS method にoptional parameter 追加 May 10, 2024
@Huzitatuguharu Huzitatuguharu changed the title managedCreateTokenForIPFS method にoptional parameter 追加 IPFSのupload先変更:NFT.Storage → Pinata May 31, 2024
@Huzitatuguharu Huzitatuguharu marked this pull request as ready for review May 31, 2024 06:46
@thashimoto1998 thashimoto1998 changed the base branch from master to release-0.1.18 May 31, 2024 07:09
Copy link
Contributor

@thashimoto1998 thashimoto1998 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NFT.storageのnpm packageを削除して下さい

@thashimoto1998 thashimoto1998 requested a review from seki-seki May 31, 2024 07:09
Copy link
Contributor

@seki-seki seki-seki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

一点コメントしましたが、他はLGTMです
as使ったところは本当に必要か最後にチェックしといてください

this.client = new NFTStorage({ token: ipfsNftStorageKey });
const pinataEndpoint = "https://api.pinata.cloud/pinning/pinFileToIPFS";

function isNode() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isNodeとかrunningOnBrowserとか(いっぱいあったはず) envUtil的なものに切出してください

@Huzitatuguharu Huzitatuguharu merged commit 250f064 into release-0.1.18 Jun 3, 2024
1 check passed
@Huzitatuguharu Huzitatuguharu deleted the feature/IPFS-optionalparameter-add branch June 3, 2024 03:12
@Huzitatuguharu Huzitatuguharu mentioned this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants