definitions added to all requests and responses based on TM #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skinkie
reviewed
Oct 11, 2023
OJP/OJP_Requests.xsd
Outdated
| <xs:element name="OJPFareRequest" type="OJPFareRequestStructure" substitutionGroup="siri:AbstractFunctionalServiceRequest"/> | ||
| <xs:element name="OJPFareRequest" type="OJPFareRequestStructure" substitutionGroup="siri:AbstractFunctionalServiceRequest"> | ||
| <xs:annotation> | ||
| <xs:documentation>This service provides general, stop-specific and trip-specific fare information. This service implements PI Stop Fare Request, PI FQ Fare Product Request, PI FQ Single Trip Fare Request from TM6.</xs:documentation> |
There was a problem hiding this comment.
I think I want to know what "FQ" is.
skinkie
reviewed
Oct 11, 2023
OJP/OJP_Requests.xsd
Outdated
| <xs:annotation> | ||
| <xs:documentation>The Location Information service comprises the following four base functions: | ||
| matching text input against possible origin and destination locations, retrieval of all location objects (bunch delivery), geographical context service that provides location objects within a bounding box, reverse address resolution service that delivers the nearest address for a given coordinate. | ||
| By means of abstraction these functions are assembled within one single service – the Location Information service. This way, even more possible applications have arisen, such as: finding the nearest stops/stations for a given coordinate, matching text input against the names of locations near a given coordinate. This service implements PI QR Location Request from TM 6.</xs:documentation> |
There was a problem hiding this comment.
QR?
TM 6 -> TM6? (consistency)
There was a problem hiding this comment.
This are all packages from TM
ue71603
commented
Oct 12, 2023
trurlurl
previously requested changes
Oct 12, 2023
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
Co-authored-by: trurlurl <[email protected]>
ue71603
force-pushed
the
definitions-for-requests
branch
from
12225db to
2b50f47
Compare
This just seems to have been missed when resolving conversations... Co-authored-by: Matthias Günter <[email protected]>
This just seems to have been missed when resolving conversations...
skinkie
reviewed
Oct 15, 2023
skinkie
reviewed
Oct 15, 2023
trurlurl
approved these changes
Oct 16, 2023
skinkie
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #405